Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CUDA C++ Execution Model documentation #3873

Merged
merged 58 commits into from
Feb 26, 2025
Merged

Initial CUDA C++ Execution Model documentation #3873

merged 58 commits into from
Feb 26, 2025

Conversation

gonzalobg
Copy link
Collaborator

@gonzalobg gonzalobg commented Feb 20, 2025 •
edited
Loading

Description

Initial documentation for the CUDA C++ Execution Model. We can expand this overtime but we need to start somewhere.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@gonzalobg gonzalobg requested a review from a team as a code owner February 20, 2025 12:57
@gonzalobg gonzalobg requested a review from gonidelis February 20, 2025 12:58
gonzalobg and others added 3 commits February 21, 2025 17:36
@gonzalobg @mhoemmen
Fix typo
fb3b573 
Co-authored-by: Mark Hoemmen <[email protected]>
@gonzalobg @mhoemmen
Rephrase note
39fc26e 
Co-authored-by: Mark Hoemmen <[email protected]>
@gonzalobg @mhoemmen
Rephrase
3fbab9d 
Co-authored-by: Mark Hoemmen <[email protected]>
@gonzalobg
Copy link
Collaborator Author

pre-commit.ci autofix

@gonzalobg gonzalobg changed the title Draft: Initial CUDA C++ Execution Model documentation Initial CUDA C++ Execution Model documentation Feb 24, 2025
@gonzalobg
Copy link
Collaborator Author

pre-commit.ci autofix

@gonzalobg
Fix bug
2334ebc 
The old wording may allow non steps to start executing (e.g. non atomic data accesses). Just saying that it does not start should suffice to prevent evaluating any expression.
@gonzalobg
Copy link
Collaborator Author

We slept on this, re-reviewed, and everyone is happy now.
We may still tweak some of the words over time as we discover issues or strengthen some of the guarantees later.
For now, ship it.

@jrhemstad jrhemstad merged commit 2895b96 into NVIDIA:main Feb 26, 2025
2 checks passed
@alliepiper
Copy link
Collaborator

Looks like this isn't building cleanly in CI: https://github.com/NVIDIA/cccl/actions/runs/13553254030/job/37881723406?pr=3948

alliepiper added a commit to alliepiper/cccl that referenced this pull request Feb 26, 2025
@alliepiper
Revert "Initial CUDA C++ Execution Model documentation (NVIDIA#3873)"
6526676 
This reverts commit 2895b96, which broke the docs build.
@alliepiper alliepiper mentioned this pull request Feb 26, 2025
Merged
jrhemstad pushed a commit that referenced this pull request Feb 26, 2025
@alliepiper
Revert "Initial CUDA C++ Execution Model documentation (#3873)" (#3950)
86f8f87 
This reverts commit 2895b96, which broke the docs build.
@gonzalobg gonzalobg mentioned this pull request Feb 27, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

@daniellustig daniellustig daniellustig left review comments

@ericniebler ericniebler ericniebler approved these changes

@miscco miscco miscco approved these changes

@gonidelis gonidelis Awaiting requested review from gonidelis gonidelis is a code owner automatically assigned from NVIDIA/cccl-codeowners

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gonzalobg @alliepiper @ericniebler @mhoemmen @miscco @daniellustig @jrhemstad